timers: use custom inspection for linked lists#23108
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the timers 
BridgeARforce-pushed the smaller-domain branch from 735f080 to 9de81efCompare
Inspecting linked lists is something that is not really useful. Instead, just use a custom inspection function and hide everything besides the first level.
BridgeARforce-pushed the smaller-domain branch from 64f471c to 1ad6994Compare
Fishrock123 approved these changes Sep 26, 2018
Contributor
Fishrock123 left a comment
Fishrock123 left a comment There was a problem hiding this comment.
SGTM although it'd be nice if there was a way to only ignore [TimersList]s here. If a user attaches an object it should probably still inspect as normal...
MemberAuthor
BridgeAR commented Sep 27, 2018
@Fishrock123 it would be possible inspecting the object deeper using |
MemberAuthor
BridgeAR commented Sep 28, 2018
@nodejs/timers @nodejs/util PTAL |
jasnell approved these changes Sep 28, 2018
apapirovski approved these changes Sep 29, 2018
benjamingr approved these changes Sep 29, 2018
Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/17545/ ✔️ (besides Windows fanned) |
MemberAuthor
BridgeAR commented Oct 1, 2018
Rebuild Windows fanned https://ci.nodejs.org/job/node-test-commit-windows-fanned/21167/ |
BridgeAR added the author ready Contributor
danbev commented Oct 2, 2018
Landed in d8baf67. |
danbev pushed a commit that referenced this pull request Oct 2, 2018
Inspecting linked lists is something that is not really useful. Instead, just use a custom inspection function and hide everything besides the first level. PR-URL: #23108 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Oct 3, 2018
Inspecting linked lists is something that is not really useful. Instead, just use a custom inspection function and hide everything besides the first level. PR-URL: #23108 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced Oct 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspecting linked lists is something that is not really useful.
Instead, just use a custom inspection function and hide everything
besides the first level.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes