deps: add no-strict-aliasing to ICU cflags

[danbev]

This commit adds -Wno-strict-aliasing to the icu_implementation target.
The motivation for this is that this flags is enabled when building with
macosx, and will make the output a little cleaner when building on
other operating systems.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1034/pipeline

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/17463/

[danbev]

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/17485/

[refack]

FYI, I have a WIP PR #22920, part of is to ignore warnings on /deps/ and only warn for /src/

 common.gypi | 1 - node.gypi | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index e87bb0f5a4..4b436ac828 100644 --- a/common.gypi+++ b/common.gypi@@ -367,7 +367,6 @@ 'ldflags': [ '-pthread' ], }], [ 'OS in "linux freebsd openbsd solaris android aix cloudabi"',{- 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ], 'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++1y' ], 'ldflags': [ '-rdynamic' ], 'target_conditions': [ diff --git a/node.gypi b/node.gypi index db29084335..15d8a02bcc 100644 --- a/node.gypi+++ b/node.gypi@@ -24,6 +24,7 @@ }, 'force_load%': '<(force_load)', }, + 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ], 'conditions': [ [ 'node_shared=="false"',{'msvs_settings':{

[addaleax]

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/17526/

[danbev]

Re-run of failing node-test-commit-arm.
Re-run of failing node-test-commit-windows-fanned.

[danbev]

Landed in f01adb5.