src: make req_wrap a unique_ptr in AfterConnect#23115
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
ContributorAuthor
danbev commented Sep 27, 2018
Member
gireeshpunathil commented Sep 27, 2018
On a slightly un-related note; what is the general convention on the responsibility of deleting heap objects - is it rested with the caller or callee (creator or consumer) ? or is it decided on a case basis? In the absence of a clear guidance, spotting memory leaks may be difficult? |
gireeshpunathil approved these changes Sep 27, 2018
targos approved these changes Sep 27, 2018
ContributorAuthor
danbev commented Sep 27, 2018
I would say that it depends on the situation and who owns the pointer, so it would be on a case basis I think. |
addaleax approved these changes Sep 27, 2018
cjihrig approved these changes Sep 27, 2018
thefourtheye approved these changes Sep 27, 2018
danbevforce-pushed the connection_wrap_unique_ptr branch 2 times, most recently from 7b202f3 to 312c959CompareContributorAuthor
danbev commented Sep 28, 2018
joyeecheung approved these changes Sep 28, 2018
jasnell approved these changes Sep 28, 2018
addaleax added the author ready 
Member
addaleax commented Sep 30, 2018
ContributorAuthor
Re-run of failing node-test-commit-windows-fanned/ ✔️ |
ContributorAuthor
danbev commented Oct 1, 2018
Landed in 5c855a7. |
danbev added a commit that referenced this pull request Oct 1, 2018
PR-URL: #23115 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2018
PR-URL: #23115 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 3, 2018
PR-URL: #23115 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes