src: remove unused locale.h#23120
Closed
src: remove unused locale.h #23120
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
addaleax approved these changes Sep 27, 2018
thefourtheye approved these changes Sep 27, 2018
Contributor
thefourtheye left a comment
thefourtheye left a comment There was a problem hiding this comment.
LGTM if the CI is happy.
This commit removes the locale.h header as it does not look like it is used.
danbevforce-pushed the node_remove_locale_header branch from ee37883 to 399576bCompare
ContributorAuthor
danbev commented Sep 28, 2018
jasnell approved these changes Sep 28, 2018
Member
addaleax commented Sep 30, 2018
Can’t do ARM-only rebuilds atm, so here’s a complete rebuild: https://ci.nodejs.org/job/node-test-pull-request/17530/ |
ContributorAuthor
danbev commented Oct 1, 2018
ContributorAuthor
danbev commented Oct 1, 2018
danbev added a commit that referenced this pull request Oct 1, 2018
This commit removes the locale.h header as it does not look like it is used. PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
danbev added a commit that referenced this pull request Oct 1, 2018
PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2018
This commit removes the locale.h header as it does not look like it is used. PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2018
PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 3, 2018
This commit removes the locale.h header as it does not look like it is used. PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 3, 2018
PR-URL: #23120 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the locale.h header as it does not look like it is
used.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes