http2: don't send trailers on a closed connection#23146
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed
nodejs-github-bot added dont-land-on-v6.x http2 
jasnell approved these changes Sep 28, 2018
trivikr approved these changes Sep 29, 2018
Member
trivikr commented Sep 29, 2018
ContributorAuthor
edevil commented Sep 29, 2018
@trivikr I’m not familiar with node’s CI. Are those failures flakes, or can they be related to this PR? Thanks. |
Member
Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17512/ (:heavy_check_mark:) |
addaleax added the author ready 
Contributor
danbev commented Oct 3, 2018
Landed in 1bfd035. |
danbev pushed a commit that referenced this pull request Oct 3, 2018
There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed PR-URL: #23146 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2018
There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed PR-URL: #23146 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
damianobarbati commented Oct 5, 2018
@danbev is there an expected release date for v10.11.1 (or v10.12.0) shipping this fix? |
This was referenced Oct 10, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed PR-URL: #23146 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
2 tasks
StephenLynx commented Nov 19, 2018
I'm getting this issue sometimes when trying to write headers using http2. Node 10.13 on CentOS 7. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAddresses koajs/koa#1229 and #22135.