tools: update ESLint to 5.6.1#23149
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update ESLint to 5.6.1.
Member
Trott commented Sep 28, 2018
(Lite CI sufficient since that runs the linter.) |
Trott added the author ready 
silverwind approved these changes Sep 29, 2018
Contributor
danbev commented Oct 1, 2018
Sorry, I saw this after I started a full CI. |
Contributor
danbev commented Oct 1, 2018
Landed in bb00eda. |
danbev pushed a commit that referenced this pull request Oct 1, 2018
Update ESLint to 5.6.1. PR-URL: #23149 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2018
Update ESLint to 5.6.1. PR-URL: #23149 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
targos pushed a commit that referenced this pull request Oct 3, 2018
Update ESLint to 5.6.1. PR-URL: #23149 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This was referenced Oct 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 5.6.1.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes