doc: specify cluster worker.kill() caveat#23165
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added cluster 
Contributor
thefourtheye commented Sep 29, 2018
Do we need any tests which back this text? |
lpinca approved these changes Sep 29, 2018
ContributorAuthor
@thefourtheye I added a test for |
Contributor
thefourtheye commented Oct 4, 2018
@cjihrig Fair enough 👍 |
thefourtheye approved these changes Oct 4, 2018
worker.kill() relies on a graceful disconnect, which might not always be possible. This commit calls this out in the docs, and specifies worker.process.kill() as a non-graceful alternative. PR-URL: nodejs#23165Fixes: nodejs#22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Verify that worker.process.kill() can terminate a cluster worker stuck in an infinite loop. PR-URL: nodejs#23165Fixes: nodejs#22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
ContributorAuthor
cjihrig commented Oct 4, 2018
targos pushed a commit that referenced this pull request Oct 5, 2018
worker.kill() relies on a graceful disconnect, which might not always be possible. This commit calls this out in the docs, and specifies worker.process.kill() as a non-graceful alternative. PR-URL: #23165Fixes: #22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Oct 5, 2018
Verify that worker.process.kill() can terminate a cluster worker stuck in an infinite loop. PR-URL: #23165Fixes: #22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Oct 10, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
worker.kill() relies on a graceful disconnect, which might not always be possible. This commit calls this out in the docs, and specifies worker.process.kill() as a non-graceful alternative. PR-URL: #23165Fixes: #22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Verify that worker.process.kill() can terminate a cluster worker stuck in an infinite loop. PR-URL: #23165Fixes: #22703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
worker.kill()relies on a graceful disconnect, which might not always be possible. This commit calls this out in the docs, and specifiesworker.process.kill()as a non-graceful alternative.Fixes: #22703
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes