build: add loader path to rpath for cctest#23168
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable.
nodejs-github-bot added the build MemberAuthor
rubys commented Sep 29, 2018
3 tasks
richardlau approved these changes Sep 29, 2018
MemberAuthor
rubys commented Sep 29, 2018
|
Member
addaleax commented Sep 30, 2018
/cc @nodejs/platform-macos |
MemberAuthor
rubys commented Sep 30, 2018
MemberAuthor
rubys commented Sep 30, 2018
Restart node test commit: https://ci.nodejs.org/job/node-test-commit/21891/ |
refack approved these changes Sep 30, 2018
MemberAuthor
rubys commented Oct 1, 2018
Sigh* Each run has a different set of transient errors. New CI: https://ci.nodejs.org/job/node-test-pull-request/17549/ |
Member
mcollina commented Oct 1, 2018
MemberAuthor
rubys commented Oct 1, 2018
Member
mhdawson commented Oct 1, 2018
@yhwang can you take a look? |
MemberAuthor
rubys commented Oct 1, 2018
jasnell approved these changes Oct 1, 2018
MemberAuthor
rubys commented Oct 1, 2018
cc @nodejs/build I'm looking for advice here. I'm adding an option that only applies to shared library builds on Mac OS/X. None of the CI tests are for shared library builds. Despite this, every time I run, I see an intermittent failure (e.g. timeout) on either Linux or Windows. |
Contributor
refack commented Oct 1, 2018
Am I wrong, but https://ci.nodejs.org/job/node-test-pull-request/17564/ seems to be green. |
Contributor
danbev commented Oct 4, 2018
Landed in 6696354. |
danbev pushed a commit that referenced this pull request Oct 4, 2018
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. PR-URL: #23168 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 5, 2018
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. PR-URL: #23168 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. PR-URL: #23168 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Mar 20, 2019
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. PR-URL: nodejs#23168 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
BethGriggs pushed a commit that referenced this pull request Mar 20, 2019
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. Backport-PR-URL: #25681 PR-URL: #23168 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on Mac OS/X as follows:
Results in:
This change adds the loader path to the runtime path for the
cctestexecutable.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes