Skip to content

Revert "tools,gyp: don't force build actions with multiple outputs"#23257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thefourtheye wants to merge 1 commit into from
Closed

Revert "tools,gyp: don't force build actions with multiple outputs" #23257

thefourtheye wants to merge 1 commit into from

Conversation

@thefourtheye
Copy link
Contributor

@thefourtheyethefourtheye commented Oct 4, 2018

This reverts commit 5d8373a.

Fixes: #23255

cc @refack@devsnek@targos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2018

@thefourtheye build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1122/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 4, 2018
@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Could this be fast-tracked? If you think so please add a 👍

@thefourtheye
Copy link
ContributorAuthor

thefourtheye commented Oct 4, 2018

As per @danbev's comment #23255 (comment), make clean fixes this problem.

@thefourtheyethefourtheye deleted the unblock-local-make branch October 4, 2018 08:35
@cjihrigcjihrig mentioned this pull request Oct 4, 2018
Closed
@thefourtheyethefourtheye restored the unblock-local-make branch October 4, 2018 13:39
@thefourtheye
Copy link
ContributorAuthor

thefourtheye commented Oct 4, 2018

Reopening as per #23255 (comment). Even my rebuild after make clean stopped responding.

@refack
Copy link
Contributor

refack commented Oct 4, 2018

Well, back to the drawing board for me 🤷‍♂️

@refackrefack added the regression Issues related to regressions. label Oct 4, 2018
@refack
Copy link
Contributor

refack commented Oct 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17630/

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 4, 2018
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

Landed in 17a0cd2

@addaleaxaddaleax closed this Oct 4, 2018
addaleax pushed a commit that referenced this pull request Oct 4, 2018
@thefourtheye@addaleax
Revert "tools,gyp: don't force build actions with multiple outputs"
17a0cd2
This reverts commit 5d8373a. Fixes: #23255 PR-URL: #23257 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@devsnek
Copy link
Member

devsnek commented Oct 5, 2018

This hasn't fixed the problem for me :(

@danbev
Copy link
Contributor

danbev commented Oct 5, 2018

@devsnek Just wanted to ask if you have done another make clean. I ran into this once more yesterday after updating master (I'm not exactly sure but I think it was after 9800fd7). After doing a make clean I've not seen it again. This might just be a coincidence but my thinking was that perhaps one of the generated makefiles was stale in some way (missing dependency or something like) causing this and was the reason I did a clean again. I'm on mac by the way just incase that might matter.

targos pushed a commit that referenced this pull request Oct 5, 2018
@thefourtheye@targos
Revert "tools,gyp: don't force build actions with multiple outputs"
a656268
This reverts commit 5d8373a. Fixes: #23255 PR-URL: #23257 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@refackrefack mentioned this pull request Oct 5, 2018
Closed
2 tasks
@targostargos mentioned this pull request Oct 10, 2018
Merged
@beevelopbeevelop mentioned this pull request Oct 10, 2018
Closed
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@targostargos mentioned this pull request Oct 17, 2018
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@thefourtheye@jasnell
Revert "tools,gyp: don't force build actions with multiple outputs"
0e33493
This reverts commit 5d8373a. Fixes: #23255 PR-URL: #23257 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@targostargos mentioned this pull request Oct 24, 2018
Merged
3 tasks
@refackrefack mentioned this pull request Oct 30, 2018
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@refackrefackrefack approved these changes

@danbevdanbevdanbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.regressionIssues related to regressions.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make with -j hangs

7 participants

@thefourtheye@nodejs-github-bot@danbev@refack@addaleax@devsnek@cjihrig