Skip to content

Conversation

@tomleah
Copy link
Contributor

@tomleahtomleah commented Oct 5, 2018

Saw that #19164 needed a backport, PTAL
cc: @gibfahn @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

This is already true in practice. PR-URL: #19164Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v8.x labels Oct 5, 2018
@BethGriggs
Copy link
Member

ping @nodejs/build (I don't think editing the description pings)

@BethGriggs
Copy link
Member

BethGriggs commented Oct 30, 2018

Landed in 104fbc6

BethGriggs pushed a commit that referenced this pull request Oct 30, 2018
This is already true in practice. Backport-PR-URL: #23275 PR-URL: #19164Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tomleah@BethGriggs@nodejs-github-bot@gibfahn