Skip to content

Conversation

@gabrielschulhof
Copy link
Contributor

Move it to the nodejs.org repo.

Checklist

Move it to the nodejs.org repo.
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2018
@gabrielschulhof
Copy link
ContributorAuthor

@gabrielschulhofgabrielschulhof mentioned this pull request Oct 7, 2018
3 tasks
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the node-api Issues and PRs related to the Node-API. label Oct 7, 2018
@gabrielschulhof
Copy link
ContributorAuthor

@gabrielschulhof
Copy link
ContributorAuthor

Landed in fd6a7d4.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Oct 7, 2018
Move it to the nodejs.org repo. PR-URL: nodejs#23303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
@gabrielschulhofgabrielschulhof deleted the remove-abi-guide branch October 7, 2018 16:05
@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 7, 2018
@Trott
Copy link
Member

Trott commented Oct 8, 2018

Theoretically, this shouldn't have landed quite yet because the second 👍 was not from a Collaborator on the core repo. But that's OK, I'm going to add a post-facto 👍 right now! 😆

@Trott
Copy link
Member

Trott commented Oct 8, 2018

Theoretically, this shouldn't have landed quite yet because the second 👍 was not from a Collaborator on the core repo. But that's OK, I'm going to add a post-facto 👍 right now! 😆

(This would be a possible argument for either eliminating wait times altogether or else automating more. I know there's been talk about having ncu check fast-track approvals but I'm not sure what obstacles might exist. OK, I'll stop rambling...)

@gabrielschulhof
Copy link
ContributorAuthor

@Trott Thanks! Maybe we should edit into the request to 👍 instead of reacting to it with an emoji:

Add your 👍 here to fast-track:<👍s go here>

jasnell pushed a commit that referenced this pull request Oct 17, 2018
Move it to the nodejs.org repo. PR-URL: #23303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielschulhof@nodejs-github-bot@vsemozhetbyt@Trott@targos