doc: simplify and clarify README language#23322
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Continued simplification and clarification of language in README.md.
trivikr approved these changes Oct 8, 2018
cjihrig approved these changes Oct 8, 2018
jasnell approved these changes Oct 8, 2018
targos approved these changes Oct 8, 2018
richardlau approved these changes Oct 8, 2018
Trott added the author ready 
vsemozhetbyt approved these changes Oct 8, 2018
ChALkeR approved these changes Oct 9, 2018
MemberAuthor
Trott commented Oct 10, 2018
Landed in 3e809e7 |
Trott added a commit to Trott/io.js that referenced this pull request Oct 10, 2018
Continued simplification and clarification of language in README.md. PR-URL: nodejs#23322 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
targos pushed a commit that referenced this pull request Oct 10, 2018
Continued simplification and clarification of language in README.md. PR-URL: #23322 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
This was referenced Oct 10, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Continued simplification and clarification of language in README.md. PR-URL: #23322 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued simplification and clarification of language in README.md.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes