build: restore js2c direct dependency on config.gypi#23355
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
addaleax approved these changes Oct 9, 2018
joyeecheung approved these changes Oct 9, 2018
richardlau approved these changes Oct 9, 2018
danbev approved these changes Oct 10, 2018
Contributor
danbev commented Oct 10, 2018
@refack Thanks for the quick fix! Could this be fast-tracked perhaps? |
Member
richardlau commented Oct 10, 2018
I think the blank line issue has been fixed in core-validate-commit (nodejs/core-validate-commit#29 (comment)) so I've restarted the Travis CI. |
2 tasks
Contributor
danbev commented Oct 10, 2018
ContributorAuthor
refack commented Oct 10, 2018
Need another 👍 for fast-tracking. |
PR-URL: nodejs#23355Fixes: nodejs#23352 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
refackforce-pushed the fix-js2c-config.gypi-dependenacy branch from 7bd8623 to 484e4dbCompareContributorAuthor
refack commented Oct 10, 2018
Fast-tracked with 2 approvals. |
targos pushed a commit that referenced this pull request Oct 10, 2018
PR-URL: #23355Fixes: #23352 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
PR-URL: #23355Fixes: #23352 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23352
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes