Skip to content

test: fix assertions args order in test/parallel/test-fs-chmod.js#23507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
milsosa wants to merge 1 commit into from
Closed

test: fix assertions args order in test/parallel/test-fs-chmod.js #23507

milsosa wants to merge 1 commit into from

Conversation

@milsosa
Copy link
Contributor

@milsosamilsosa commented Oct 12, 2018

Fix assertions arguments order in test/parallel/test-fs-chmod.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targostargos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@milsosa
Copy link
ContributorAuthor

milsosa commented Oct 12, 2018

Done @trivikr, thanks!

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@milsosa@BridgeAR
test: fix assertions args order in test/parallel/test-fs-chmod.js
c205e8c
PR-URL: nodejs#23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@milsosa@BridgeAR
test: fix assertions args order in test/parallel/test-fs-chmod.js
008b97a
PR-URL: nodejs#23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 15, 2018

Landed in 008b97a 🎉

@milsosa congratulations on your commit to Node.js!

@milsosa
Copy link
ContributorAuthor

milsosa commented Oct 15, 2018

Awesome!

Thanks @BridgeAR, I will try to do my best to continue contributing to Node.js.

@milsosamilsosa deleted the fix-assertions branch October 15, 2018 13:47
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@milsosa@jasnell
test: fix assertions args order in test/parallel/test-fs-chmod.js
8cc52b0
PR-URL: #23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@milsosa@addaleax
test: fix assertions args order in test/parallel/test-fs-chmod.js
dd86c16
PR-URL: #23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@milsosa@MylesBorins
test: fix assertions args order in test/parallel/test-fs-chmod.js
119fc3a
PR-URL: #23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@milsosa@rvagg
test: fix assertions args order in test/parallel/test-fs-chmod.js
adede5c
PR-URL: #23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@milsosa@MylesBorins
test: fix assertions args order in test/parallel/test-fs-chmod.js
7577de5
PR-URL: #23507 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@milsosa@BridgeAR@jasnell@cjihrig@gireeshpunathil@trivikr@targos@nodejs-github-bot