test: skip failing tests for osx mojave#23550
Uh oh!
There was an error while loading. Please reload this page.
Conversation
BridgeAR added the code-and-learn 
gdams commented Oct 12, 2018
FYI I am currently working on adding Mojave to ci.nodejs.org. Should be in there by the end of the day |
Trott commented Oct 12, 2018
One downside is that the test will continue to be skipped after the bug in Mojave is fixed. |
gdams commented Oct 15, 2018
gdams added the author ready 
refack commented Oct 15, 2018
@jnord99 could you add test that fails to |
cjihrig commented Oct 15, 2018
I would not recommend moving them to |
Trott commented Oct 15, 2018
I don't think this is a good candidate for |
refack commented Oct 15, 2018
Ack, Not moving. Adding a new one with the opposite condition, i.e.: // Fail on OS X Mojave. https://github.com/nodejs/node/issues/21679if(!common.isOSXMojave)common.skip('bypass test for non macOS Mojave'); ... Dosomethingthatfails ... |
jnord99 commented Oct 15, 2018
the update skips the test if it is Mojave. It already was doing the same for Windows. It will execute the test for other systems. |
Added a "known_issue" test in https://github.com/nodejs/node/pull/23550/commits/cbc55b0874bd9742fd33cb27a14b4dd94d0e48d9to track this. Unfortunately we can't CI it. @nodejs/platform-macos anyone can verify? |
There was a problem hiding this comment.
LGTM.
One downside is that the test will continue to be skipped after the bug in Mojave is fixed.
That is correct, but this is obviously better than scaring off all macOS users from contributing because they can't get tests to pass on their platform.
We can revisit it later once/if the issue gets fixed.
Also, this checks specifically for =18, not >=18.
So any macOS version later than Mojave would have this test running again, either passing (if that gets fixed) or failing (so we revisit again and would have to update the test once more).
Trott commented Oct 18, 2018
addaleax commented Oct 21, 2018
Landed in eff869f Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Refs: #21679 PR-URL: #23550 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
15 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes