src: remove function hasTextDecoder in encoding.js#23625
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the encoding 
addaleax approved these changes Oct 12, 2018
Member
addaleax commented Oct 12, 2018
addaleax added the author ready 
jasnell approved these changes Oct 12, 2018
Contributor
mscdex commented Oct 12, 2018
Can we also get rid of |
ContributorAuthor
@mscdex It appears that It appears we can return the constructor directly from both TextDecoder factories. I'll make the change. |
cjihrig approved these changes Oct 13, 2018
Member
Trott commented Oct 13, 2018
Member
Trott commented Oct 13, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17805 |
thefourtheye approved these changes Oct 13, 2018
Member
Trott commented Oct 13, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17817/ |
Contributor
danbev commented Oct 16, 2018
Re-run of failing node-test-commit-linux |
Member
Trott commented Oct 16, 2018
The Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17887/ |
ContributorAuthor
chichiwang commented Oct 16, 2018
@Trott Thanks! There still appears to be one failure in the run. Let me know if I can do anything to help resolve the CI failures (like rebase the branch against master). |
Contributor
refack commented Oct 16, 2018
Member
jasnell commented Oct 16, 2018
Getting this landed. |
jasnell pushed a commit that referenced this pull request Oct 16, 2018
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
jasnell commented Oct 16, 2018
Landed in 25dc25b |
jasnell pushed a commit that referenced this pull request Oct 17, 2018
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
3 tasks
codebytere pushed a commit that referenced this pull request Dec 13, 2018
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
This was referenced Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
hasTextDecoderin/lib/internal/encoding.js.hasTextDecoderis unused. This has the benefit of increasing test coverage.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes