deps: upgrade to c-ares v1.15.0#23854
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time.
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself.
Not yet upstream. Refs: c-ares/c-ares#229
nodejs-github-bot added build 
Contributor
refack commented Oct 24, 2018
Probably should remove: Line 38 in aaa3017 |
refack approved these changes Oct 24, 2018
cjihrig approved these changes Oct 24, 2018
MemberAuthor
CI once more: https://ci.nodejs.org/job/node-test-pull-request/18178/ (edit: green) Previous one had a couple of (what are probably) flakes. |
Member
Trott commented Nov 6, 2018
Any reason this shouldn't land? Seems ready to go. (Should it land as one, two, or three separate commits?) |
Member
addaleax commented Nov 6, 2018
Landed in aa82a21...7b1297d |
4 tasks
addaleax pushed a commit that referenced this pull request Nov 6, 2018
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 6, 2018
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 6, 2018
Not yet upstream. Refs: c-ares/c-ares#229 PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2018
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2018
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2018
Not yet upstream. Refs: c-ares/c-ares#229 PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Nov 15, 2018
codebytere pushed a commit that referenced this pull request Nov 29, 2018
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
Not yet upstream. Refs: c-ares/c-ares#229 PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Not yet upstream. Refs: c-ares/c-ares#229 PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
Remove leftover files that were added in commit 58e4eda from 2013 to help with standalone builds of the c-ares fork that we maintained at the time. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad fec0 prefix") should no longer be necessary, c-ares now blacklists such addresses itself. PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
Not yet upstream. Refs: c-ares/c-ares#229 PR-URL: #23854 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 6, 2018
Notable changes: * deps: * upgrade to c-ares v1.15.0 (Ben Noordhuis) #23854 * Windows: * A crashing process will now show the names of stack frames if the node.pdb file is available. (Refael Ackermann) #23822 * Added new collaborators: * Peter Marshall. #24170 * Masashi Hirano. #24136 PR-URL: #24727
MylesBorins pushed a commit that referenced this pull request Dec 11, 2018
Notable changes: * deps: * upgrade to c-ares v1.15.0 (Ben Noordhuis) #23854 * Windows: * A crashing process will now show the names of stack frames if the node.pdb file is available. (Refael Ackermann) #23822 * Added new collaborators: * Peter Marshall. #24170 * Masashi Hirano. #24136 PR-URL: #24727
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Notable changes: * deps: * upgrade to c-ares v1.15.0 (Ben Noordhuis) nodejs#23854 * Windows: * A crashing process will now show the names of stack frames if the node.pdb file is available. (Refael Ackermann) nodejs#23822 * Added new collaborators: * Peter Marshall. nodejs#24170 * Masashi Hirano. nodejs#24136 PR-URL: nodejs#24727
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/18116/CI: https://ci.nodejs.org/job/node-test-pull-request/18119/