Skip to content

Conversation

@dexterleng
Copy link
Contributor

@dexterlengdexterleng commented Oct 28, 2018

Issue #21431

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 28, 2018
Co-Authored-By: dexterleng <[email protected]>
@dexterleng
Copy link
ContributorAuthor

ping @jasnell

@Trott
Copy link
Member

Trott commented Nov 4, 2018

@nodejs/streams @nodejs/documentation This could use some reviews.

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is slightly different, and the meaning as well. writable is true when it's safe to call write(), and readable is true when it's safe to call read().

The problem is that some of the core and ecosystem streams sets readable or writable to false to take into account a delayed open scenario.

@dexterleng
Copy link
ContributorAuthor

The default value is slightly different, and the meaning as well.

@mcollina Could you elaborate? In the constructor of Readable and Writable the properties are both true.

@mcollina
Copy link
Member

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 21, 2018
@Trott
Copy link
Member

Landed in 16a2b5c.

Thanks for the contribution! 🎉

@codebyterecodebytere mentioned this pull request Jan 15, 2019
@MylesBorins
Copy link
Contributor

FWIW this landed with REPLACEME tags and subsequently got updated with an 11.x number for when it landed... which is innacurate

codebytere pushed a commit that referenced this pull request Jan 29, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dexterleng@Trott@mcollina@MylesBorins@jasnell@nodejs-github-bot