test: assert that invalidcmd throws error code#23942
Uh oh!
There was an error while loading. Please reload this page.
Conversation
There was a problem hiding this comment.
Can we simply change the second argument to 13 here and reuse invalidArgTypeError instead of defining invalidArgTypeErrorCallsOnce?
There was a problem hiding this comment.
👍 yes of course.
jeromecovingtonforce-pushed the refactor/test-child-process-spawn-typeerror branch from 2349ac6 to d69a3d5Compare
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Oct 29, 2018
Trott added the author ready 
jeromecovington commented Oct 31, 2018
I was able to trace the test-commit failure to this error which seems harmless enough, although this is the first time I've tracked something like this down. |
Trott commented Oct 31, 2018
CI resume build: https://ci.nodejs.org/job/node-test-pull-request/18268/ |
jeromecovington commented Nov 1, 2018
The travis ci error I'm seeing is: ...Presumably for the commit message guidelines, but I think I covered that? The subsystem is |
jeromecovington commented Nov 1, 2018
...Oh...the subsystem looks to be |
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code.
jeromecovingtonforce-pushed the refactor/test-child-process-spawn-typeerror branch from d69a3d5 to b55906eComparejeromecovington changed the title jeromecovington commented Nov 1, 2018
Hm. Updated the subsystem from |
richardlau commented Nov 1, 2018
Travis is linting the wrong commit (9d7895c, which happens to be the very first commit in this repository). cc fyi @Trott |
richardlau commented Nov 1, 2018
@jeromecovington You could try rebasing onto the current master branch. |
Trott commented Nov 2, 2018
Don't worry about the commit linting. It lints the first commit in the PR. If there's a problem with the commit message, our tooling for landing will alert the person landing the PR, so it's not a big deal. |
Trott commented Nov 2, 2018
Landed in 878f587 |
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: nodejs#23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott commented Nov 2, 2018
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: #23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: #23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: #23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: #23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Update invalidcmd test case in test-child-process-spawn-typeerror to assert on specific expected error code. PR-URL: #23942 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
9 participants
Update invalidcmd test case in test-child-process-spawn-typeerror to
assert on specific expected error code.
I've been interested in custom error codes in core for various reasons,
@Trott suggested this refactor as a place to start looking into usage in
tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes