Skip to content

lib: remove useless getLibuvNow in internal/timers#23995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZYSzys wants to merge 1 commit into from
Closed

lib: remove useless getLibuvNow in internal/timers #23995

ZYSzys wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

@ZYSzysZYSzys commented Oct 31, 2018

Remove unused getLibuvNow in lib/internal/timers.js since we are using this function through internalBinding('timers') directly in lib/timers.js.
Maybe make bit of optimization ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 31, 2018
@Trott
Copy link
Member

Trott commented Nov 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18308/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2018
@Trott
Copy link
Member

Trott commented Nov 4, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18323/

@Trott
Copy link
Member

Trott commented Nov 4, 2018

Landed in 22f5c08

@TrottTrott closed this Nov 4, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 4, 2018
@ZYSzys@Trott
lib: remove useless getLibuvNow in internal/timers
22f5c08
PR-URL: nodejs#23995 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
@ZYSzysZYSzys deleted the internal/timers branch November 4, 2018 02:18
targos pushed a commit that referenced this pull request Nov 5, 2018
@ZYSzys@targos
lib: remove useless getLibuvNow in internal/timers
874393b
PR-URL: #23995 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@mmarchinimmarchinimmarchini approved these changes

@ryzokukenryzokukenryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ZYSzys@Trott@jasnell@addaleax@lpinca@cjihrig@mmarchini@ryzokuken@codebytere@nodejs-github-bot