doc: fix socket.connecting description#24066
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing.
nodejs-github-bot added doc 
joyeecheung approved these changes Nov 3, 2018
lpinca approved these changes Nov 3, 2018
Trott reviewed Nov 4, 2018
| If `true`, | ||
| [`socket.connect(options[, connectListener])`][`socket.connect(options)`] | ||
| was called and haven't yet finished. Will be set to `false` before emitting | ||
| was called and has not yet finished. Will be set to `true` before emitting |
Member
There was a problem hiding this comment.
Micro-nit: While we're in here, get rid of yet?
For some other PR perhaps: What does "finished" mean in this context? The connection has not been established? I imagine it doesn't mean that the method is still executing but that is what a naive interpretation might be....
Trott added the author ready Trott approved these changes Nov 4, 2018
Member
Trott commented Nov 4, 2018
Collaborators, please 👍 here to fast track. |
Member
Trott commented Nov 4, 2018
Landed in bb25457 |
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 4, 2018
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing. PR-URL: nodejs#24066 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Nov 5, 2018
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing. PR-URL: #24066 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Nov 15, 2018
codebytere pushed a commit that referenced this pull request Nov 29, 2018
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing. PR-URL: #24066 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing. PR-URL: #24066 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
In particular, this value is `true` and not `false` between calling `connect()` and the operation finishing. PR-URL: #24066 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, this value is
trueand notfalsebetween calling
connect()and the operation finishing.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes