lib: move internalBinding whitelisting into loaders.js#24088
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined.
MemberAuthor
joyeecheung commented Nov 4, 2018
addaleax approved these changes Nov 4, 2018
devsnek approved these changes Nov 4, 2018
| 'zlib', | ||
| 'buffer', | ||
| 'natives', | ||
| 'constants' |
Member
There was a problem hiding this comment.
thank you so much for moving the closing brace to a new line
Contributor
There was a problem hiding this comment.
What's our policy about dangling commas (I'm +1 on adding one)
Member
There was a problem hiding this comment.
we have no lint rule for or against them. if it were up to me we would require them. (I'm +1 on adding one)
refack approved these changes Nov 4, 2018
| 'zlib', | ||
| 'buffer', | ||
| 'natives', | ||
| 'constants' |
Contributor
There was a problem hiding this comment.
What's our policy about dangling commas (I'm +1 on adding one)
refack added module 
cjihrig approved these changes Nov 5, 2018
joyeecheung added the author ready 
Member
Trott commented Nov 8, 2018
Landed in 7bd8bba |
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2018
Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined. PR-URL: nodejs#24088 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
joyeecheung commented Nov 8, 2018
Applied don't land labels because this is building on top of #22269 |
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined. PR-URL: #24088 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined. PR-URL: nodejs#24088 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Nov 15, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of setting the internalBinding white list in node.js and
wrapping process.binding twice, put it directly in loaders.js
where the user land process.binding is defined.