Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Nov 6, 2018

posix -> POSIX
platform specific -> platform-specific

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

posix -> POSIX platform specific -> platform-specific
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Nov 6, 2018
@Trott
Copy link
MemberAuthor

Trott commented Nov 6, 2018

Collaborators please 👍 here to fast-track.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2018
@richardlau
Copy link
Member

posix -> POSIX

This looks like a reasonable thing to lint for.

@Trott
Copy link
MemberAuthor

Trott commented Nov 6, 2018

Landed in 4415558

@TrottTrott closed this Nov 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 6, 2018
posix -> POSIX platform specific -> platform-specific PR-URL: nodejs#24118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2018
posix -> POSIX platform specific -> platform-specific PR-URL: #24118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
codebytere pushed a commit that referenced this pull request Nov 29, 2018
posix -> POSIX platform specific -> platform-specific PR-URL: #24118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
posix -> POSIX platform specific -> platform-specific PR-URL: #24118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
posix -> POSIX platform specific -> platform-specific PR-URL: #24118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@TrottTrott deleted the fix-path branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.pathIssues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@richardlau@danbev@codebytere