Skip to content

test: switch arguments in strictEqual#24141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mthpvg wants to merge 1 commit into from
Closed

test: switch arguments in strictEqual #24141

mthpvg wants to merge 1 commit into from

Conversation

@mthpvg
Copy link
Contributor

@mthpvgmthpvg commented Nov 6, 2018

In the test/parallel/test-vm-create-and-run-in-context.js test the actual and expected arguments in the assert.strictEqual() call on line 32 are in the wrong order and they have to be switched around.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mthpvg
test: switch arguments in strictEqual
fe994aa
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. :100644 100644 8f4ce72... bd746cf... M test/parallel/test-vm-create-and-run-in-context.js
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleaxaddaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18394/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 7, 2018•
edited
Loading

pls thumbs up for fast tracking

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 8, 2018

one test failure in plinux:

01:50:44 not ok 2445 pseudo-tty/no_interleaved_stdio 01:50:44 --- 01:50:44 duration_ms: 0.102 01:50:44 severity: fail 01:50:44 stack: |- 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 oooooooooooooooooooooooooooooooooooooooooooooooo 01:50:44 ooooooooooooooooooooooooO__This is some stderr__ 01:50:44 ...

I remember this failure, but can't recollect whether it was debugged or not, and if so was fixed or not.

Either case, this is unrelated to the change, but re-run CI to be sure:
new CI: https://ci.nodejs.org/job/node-test-pull-request/18412/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 9, 2018

landed as 8272e7f

thank you @mthpvg for the contribution. Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps/

gireeshpunathil pushed a commit that referenced this pull request Nov 9, 2018
@mthpvg@gireeshpunathil
test: switch arguments in strictEqual
8272e7f
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@mthpvg
Copy link
ContributorAuthor

mthpvg commented Nov 12, 2018

Thx @gireeshpunathil for your work on this commit! I'll check the link also.

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@mthpvg@BridgeAR
test: switch arguments in strictEqual
2d87ce3
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@mthpvg@kiyomizumia
test: switch arguments in strictEqual
41d4a17
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: nodejs#24141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 13, 2018
@mthpvg@codebytere
test: switch arguments in strictEqual
88231ca
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@mthpvg@MylesBorins
test: switch arguments in strictEqual
f46fa90
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Jan 4, 2019
Merged
@beevelopbeevelop mentioned this pull request Jan 29, 2019
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mthpvg@gireeshpunathil@addaleax@cjihrig@BridgeAR@trivikr@codebytere@nodejs-github-bot