test: fixed arguments order in process-getactiverequests#24186
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BridgeAR approved these changes Nov 6, 2018
gireeshpunathil approved these changes Nov 6, 2018
cjihrig approved these changes Nov 6, 2018
addaleax added the code-and-learn 
lpinca approved these changes Nov 6, 2018
ContributorAuthor
kopylash commented Nov 7, 2018
@trivikr the CI build failed, linter got an error https://travis-ci.com/nodejs/node/jobs/156703762#L459 |
Member
lpinca commented Nov 7, 2018
@kopylash commit title is a bit too log. We can use "test: fix args order in process-getactiverequests" to make linter happy. |
ContributorAuthor
kopylash commented Nov 7, 2018
I changed commit message, but it's confusing since in guidelines it is written that max length is 72 |
Member
gireeshpunathil commented Nov 9, 2018
Member
trivikr commented Nov 9, 2018
jasnell approved these changes Nov 9, 2018
Member
addaleax commented Nov 10, 2018
addaleax added the author ready 
Member
Trott commented Nov 11, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
PR-URL: nodejs#24186 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Nov 12, 2018
Landed in 981701b. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24186 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24186 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24186 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes