test: add process no deprecation#24196
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax added process 
addaleax approved these changes Nov 6, 2018
BridgeAR approved these changes Nov 6, 2018
Member
There was a problem hiding this comment.
Suggested change
| constchild=spawn(process.argv[0],[process.argv[1],'child']); | |
| constchild=spawn(process.execPath,[process.argv[1],'child']); |
lpinca approved these changes Nov 6, 2018
Member
There was a problem hiding this comment.
Suggested change
| child.stderr.setEncoding('utf8'); |
razvanbhforce-pushed the fix-no-deprecation branch from c9fadea to 097fa62Compare
jasnell approved these changes Nov 10, 2018
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM with the suggested changes
razvanbhforce-pushed the fix-no-deprecation branch from ec8bb0e to c0be069Compare
Contributor
oyyd commented Nov 13, 2018
Member
gireeshpunathil commented Nov 13, 2018
@richardlau@lpinca PTAL |
gireeshpunathil added the author ready 
richardlau approved these changes Nov 13, 2018
Member
gireeshpunathil commented Nov 13, 2018
landed as 6ae6383 , thanks |
gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Nov 15, 2018
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes