build: use latest node on travis#24198
Uh oh!
There was an error while loading. Please reload this page.
Conversation
richardlau commented Nov 6, 2018
Is this something we should pursue with Travis? 8.9.1 isn't even the latest 8.x LTS. |
cjihrig commented Nov 6, 2018
Is "latest" a recognized value in Travis? I've never seen it used before. If it is documented as a valid value, then we should probably raise the issue to them. |
Ah good point. https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions says:
|
cjihrig commented Nov 6, 2018
Since the Travis linter is currently broken, please 👍 to approve fast tracking. |
refack commented Nov 6, 2018
refack added build cjihrig commented Nov 7, 2018
The linter passed. There were two test failures, but they were both |
PR-URL: nodejs#24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
refack commented Nov 7, 2018
Fast-tracked with 4 upvotes. Validated with Lite CI + Travis. |
PR-URL: #24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #24198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
7 participants
Our Travis setup asks for the latest node version when running the linter. We're actually ending up with Node 8.9.1. Trying this instead...
Checklist
CI: https://ci.nodejs.org/job/node-test-pull-request/18379/