Skip to content

test: disable color formatting for test-internal-errors.js#24204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Nov 7, 2018
Merged

test: disable color formatting for test-internal-errors.js #24204

refack merged 1 commit into from
Nov 7, 2018

Conversation

@refack
Copy link
Contributor

@refackrefack commented Nov 6, 2018•
edited
Loading

Fixes: #24193
Refs: #19723

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2018

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1519/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@refackrefack mentioned this pull request Nov 6, 2018
Closed
@refack
Copy link
ContributorAuthor

refack commented Nov 6, 2018

/CC @nodejs/testing @nodejs/assert

@refackrefack assigned BridgeAR and refack and unassigned BridgeARNov 6, 2018
@refackrefack added assert Issues and PRs related to the assert subsystem. util Issues and PRs related to the built-in util module. labels Nov 6, 2018
@refackrefack requested a review from BridgeARNovember 6, 2018 21:12
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2018
@Trott
Copy link
Member

Trott commented Nov 6, 2018

Collaborators, 👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18380/

@danbev
Copy link
Contributor

danbev commented Nov 7, 2018

I'd be happy to merge this, but there is a pending review. Let me know if we don't have to wait. Thanks

@refackrefack removed the request for review from BridgeARNovember 7, 2018 15:16
@refackrefackforce-pushed the test-with-no-colors branch from 6ace7ec to 18a4550CompareNovember 7, 2018 15:19
@refack
Copy link
ContributorAuthor

refack commented Nov 7, 2018

I'd be happy to merge this, but there is a pending review. Let me know if we don't have to wait. Thanks

On my part it was more of a request, then a requirement.
But unless there's great urgency, the PRs I prefer to land myself, I self-assign.

@refackrefack merged commit 18a4550 into nodejs:masterNov 7, 2018
@refackrefack deleted the test-with-no-colors branch November 7, 2018 15:21
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@refack@BridgeAR
test: disable color formating for test-internal-errors.js
a2e2c91
PR-URL: #24204Fixes: #24193 Refs: #19723 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@refack@kiyomizumia
test: disable color formating for test-internal-errors.js
5807826
PR-URL: nodejs#24204Fixes: nodejs#24193 Refs: nodejs#19723 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
This was referenced Nov 16, 2018
Closed
Closed
@refackrefack removed their assignment Nov 16, 2018
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@refack@codebytere
test: disable color formating for test-internal-errors.js
9814bd9
PR-URL: #24204Fixes: #24193 Refs: #19723 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack@MylesBorins
test: disable color formating for test-internal-errors.js
f20bf8c
PR-URL: #24204Fixes: #24193 Refs: #19723 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@refack@MylesBorins
test: disable color formating for test-internal-errors.js
43097d9
PR-URL: #24204Fixes: #24193 Refs: #19723 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running a single test using --expose-internals throws an error [nodeconf code and learn]

7 participants

@refack@nodejs-github-bot@Trott@danbev@bnoordhuis@codebytere@BridgeAR