doc: use real protocol names in ALPN example#24232
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
mscdex reviewed Nov 7, 2018
Uh oh!
There was an error while loading. Please reload this page.
sam-githubforce-pushed the use-real-values-for-alpn-protocols branch from 0c42fac to 2b897c8Compare
ContributorAuthor
sam-github commented Nov 9, 2018
@mscdex PTAL |
ContributorAuthor
sam-github commented Nov 9, 2018
jasnell approved these changes Nov 10, 2018
ContributorAuthor
sam-github commented Nov 13, 2018
Landed in 7cd08eb |
sam-github added a commit that referenced this pull request Nov 13, 2018
PR-URL: #24232 Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24232 Reviewed-By: James M Snell <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24232 Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24232 Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes