Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
build: check minimum ICU in configure for system-icu#24255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Nov 8, 2018
srl295 commented Nov 8, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
else you get this: also updates 'icu_system_version': '60.2','icu_ver_major': '60', |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bnoordhuis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nothing uses/is going to use icu_system_version, can you remove it?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
srl295 commented Nov 8, 2018
@bnoordhuis I'll remove |
srl295 commented Nov 8, 2018
@bnoordhuis thanks. I think I addressed your comments. |
bnoordhuis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment.
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Nov 16, 2018
@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you? |
6695e84 to 2d0d9ceComparerefack commented Nov 16, 2018
2d0d9ce to 5c47c2bComparerefack commented Nov 16, 2018
- check the version number coming out of pkg-config PR-URL: nodejs#24255Fixes: nodejs#24253 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
5c47c2b to ed1c40eCompare- check the version number coming out of pkg-config PR-URL: #24255Fixes: #24253 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
- check the version number coming out of pkg-config PR-URL: #24255Fixes: #24253 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
- check the version number coming out of pkg-config PR-URL: #24255Fixes: #24253 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
- check the version number coming out of pkg-config PR-URL: #24255Fixes: #24253 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #24253
make -j4 test(UNIX), orvcbuild test(Windows) passes