test: add typeerror test for EC crypto keygen#24400
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
refack reviewed Nov 16, 2018
| },{ | ||
| type: TypeError, | ||
| code: 'ERR_INVALID_OPT_VALUE', | ||
| message: `The value "${namedCurve}" is invalid for option `+ |
Contributor
There was a problem hiding this comment.
No need to validate the message.
ContributorAuthor
There was a problem hiding this comment.
@refack I have to remove the validation of the message or it can be good as is?
refack approved these changes Nov 16, 2018
refack added crypto 
Contributor
refack commented Nov 16, 2018
jasnell approved these changes Nov 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
PR-URL: nodejs#24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Nov 20, 2018
Landed in 67b67ad. 🎉Thanks for the contribution! |
targos pushed a commit that referenced this pull request Nov 20, 2018
PR-URL: #24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 7, 2018
codebytere pushed a commit that referenced this pull request Jan 13, 2019
PR-URL: #24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
PR-URL: #24400 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for type error on generate EC crypto keygen when curve is not a string.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes