test: modified order of parameters for assertion#24430
Uh oh!
There was an error while loading. Please reload this page.
Conversation
BridgeAR added the code-and-learn 
targos left a comment
targos left a comment There was a problem hiding this comment.
Changes LGTM.
Commit message should start with test: modify ...
targos commented Nov 17, 2018
👍 to fast-track |
gireeshpunathil commented Nov 18, 2018
|
Trott commented Nov 19, 2018
Trott commented Nov 19, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18772/ |
| d.run(function(){ | ||
| conste=newError('error'); | ||
| constdomainError=newError('domain error'); | ||
| onUnhandledSucceed(done,function(reason,promise){ |
There was a problem hiding this comment.
Nit: A common.mustCall around this would be better.
Trott commented Nov 20, 2018
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18785/ |
Trott commented Nov 20, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18788/ |
Trott commented Nov 20, 2018
That test-stream-pipeline issue is being pretty stubborn but is also pretty clearly unrelated. Let's do a full CI: https://ci.nodejs.org/job/node-test-pull-request/18815/ |
PR-URL: nodejs#24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Trott commented Nov 20, 2018
Landed in 7ba83e8. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: nodejs#24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
11 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes