doc: fix missing PR id#24458
Closed
doc: fix missing PR id #24458
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 18, 2018
@oyyd sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot added deprecations 
richardlau approved these changes Nov 18, 2018
targos approved these changes Nov 18, 2018
vsemozhetbyt approved these changes Nov 18, 2018
vsemozhetbyt added the author ready 
Contributor
vsemozhetbyt commented Nov 18, 2018
Contributor
vsemozhetbyt commented Nov 18, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca approved these changes Nov 18, 2018
ContributorAuthor
oyyd commented Nov 18, 2018
Landed in 34eccb2. Thanks! |
pullbot pushed a commit to shakir-abdo/node that referenced this pull request Nov 18, 2018
PR-URL: nodejs#24458 Refs: nodejs#23329 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24458 Refs: nodejs#23329 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #23329
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes