test: fix test case in test-child-process-fork-dgram.js#24459
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gengjiawenforce-pushed the bugfix/test-case-child-process branch from ff8fe69 to 53f777aCompare
trivikr approved these changes Nov 19, 2018
jasnell approved these changes Nov 19, 2018
lpinca approved these changes Nov 19, 2018
lpinca reviewed Nov 19, 2018
Uh oh!
There was an error while loading. Please reload this page.
Member
lpinca commented Nov 19, 2018
MemberAuthor
gengjiawen commented Nov 20, 2018
@lpinca Do I need to squash my commits ? |
Member
lpinca commented Nov 20, 2018
@gengjiawen it would be nice, it will help whoever lands this |
gengjiawenforce-pushed the bugfix/test-case-child-process branch from dc96de1 to 758939bCompareMemberAuthor
gengjiawen commented Nov 20, 2018
@lpinca done. |
Member
addaleax commented Nov 23, 2018
addaleax added the author ready Member
addaleax commented Nov 23, 2018
Landed in 4270c13, thanks for the PR! |
addaleax pushed a commit that referenced this pull request Nov 23, 2018
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 24, 2018
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 7, 2018
codebytere pushed a commit that referenced this pull request Jan 13, 2019
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
PR-URL: #24459 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes