Change callback to ES6 style#24513
Closed
Change callback to ES6 style #24513
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BridgeAR approved these changes Nov 20, 2018
cjihrig approved these changes Nov 20, 2018
jasnell approved these changes Nov 21, 2018
gireeshpunathil added the code-and-learn 
Trott previously requested changes Nov 21, 2018
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
jamesgeorge007 commented Nov 21, 2018
@Trott What do you think now? |
gireeshpunathil approved these changes Nov 22, 2018
Member
gireeshpunathil commented Nov 22, 2018
Member
gireeshpunathil commented Nov 22, 2018
earlier CI run was aborted. new CI: https://ci.nodejs.org/job/node-test-pull-request/18879/ |
Member
addaleax commented Nov 23, 2018
@jamesgeorge007 If you could rebase out the merge commit here, that could help – our CI doesn’t play well with those. CI (rebasing disabled): https://ci.nodejs.org/job/node-test-pull-request/18890/ |
ContributorAuthor
@addaleax My working tree became dirty. Hence, I had to close the PR and reopen it again. |
Member
addaleax commented Nov 23, 2018
@jamesgeorge007 Hm … I think the linter failure from https://travis-ci.com/nodejs/node/jobs/160538871 is real: |
Member
addaleax commented Nov 24, 2018
addaleax added the author ready 
jamesgeorge007force-pushed the patch-1 branch 2 times, most recently from 2947c85 to d32d64cCompare
Member
Trott commented Nov 24, 2018
trivikr approved these changes Nov 24, 2018
Member
gireeshpunathil commented Nov 24, 2018
jamesgeorge007force-pushed the patch-1 branch 3 times, most recently from 17a9ef5 to b62fe77CompareTrott reviewed Nov 25, 2018
Uh oh!
There was an error while loading. Please reload this page.
Trott removed the author ready jamesgeorge007force-pushed the patch-1 branch 3 times, most recently from cdb949f to dee06f8Compare
add newline at EOF 👍 Add EOF 👍 fix 👍 fix 👍 fix 👍
jamesgeorge007 changed the title Member
gireeshpunathil commented Nov 25, 2018
Member
gireeshpunathil commented Nov 25, 2018
landed as afab340 thank you @jamesgeorge007 for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
gireeshpunathil pushed a commit that referenced this pull request Nov 25, 2018
PR-URL: #24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
ContributorAuthor
jamesgeorge007 commented Nov 25, 2018
👍 |
Member
gireeshpunathil commented Nov 25, 2018
@jamesgeorge007 - don't worry; your code is landed as afab340 into the repo, and you have become a contributor in the project. |
targos pushed a commit that referenced this pull request Nov 27, 2018
PR-URL: #24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
PR-URL: #24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted the es5 functions present within the
test/pummel/test-net-pause.jsto arrow (es6) functions which is more concise.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes