lib: fix nits in lib/internal/bootstrap/cache.js#24581
Closed
+31 −33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Unwrap short lines. * Unify comments. * Decrease function calls.
vsemozhetbyt added the lib / src 
ContributorAuthor
lpinca approved these changes Nov 23, 2018
addaleax approved these changes Nov 23, 2018
addaleax added the author ready 
cjihrig approved these changes Nov 24, 2018
trivikr approved these changes Nov 24, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: nodejs#24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
Trott commented Nov 25, 2018
Landed in 14707b6 |
vsemozhetbyt deleted the lib-min-func-calls-internal-bootstrap-cache.js branch targos pushed a commit that referenced this pull request Nov 27, 2018
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: #24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: #24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: nodejs#24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: #24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
* Unwrap short lines. * Unify comments. * Decrease function calls. PR-URL: #24581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes