Skip to content

doc: fix duplicate "this" and "the" on doc/api/http2.md#24611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kawanet wants to merge 1 commit into from
Closed

doc: fix duplicate "this" and "the" on doc/api/http2.md #24611

kawanet wants to merge 1 commit into from

Conversation

@kawanet
Copy link
Contributor

@kawanetkawanet commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sending this PR from the NodeFest 2018 Tokyo 🇯🇵 code-and-learn class.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Nov 24, 2018
@ronkorvingronkorving added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@addaleax
Copy link
Member

addaleax commented Nov 24, 2018

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1690/pipeline

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 24, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 24, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 24, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 24, 2018

Landed in 7c3c70c
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Nov 24, 2018
@kawanet@vsemozhetbyt
doc: fix duplicate "this" and "the" on http2.md
7c3c70c
PR-URL: #24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Nov 25, 2018
@kawanet@targos
doc: fix duplicate "this" and "the" on http2.md
2bbd7e5
PR-URL: #24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@kawanet@rvagg
doc: fix duplicate "this" and "the" on http2.md
663d1c8
PR-URL: #24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kawanet@refack
doc: fix duplicate "this" and "the" on http2.md
c025063
PR-URL: nodejs#24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@kawanet@BethGriggs
doc: fix duplicate "this" and "the" on http2.md
bda7354
PR-URL: #24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@kawanet@rvagg
doc: fix duplicate "this" and "the" on http2.md
50d0a99
PR-URL: #24611 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+3 more reviewers

@ronkorvingronkorvingronkorving approved these changes

@lundibundilundibundilundibundi approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kawanet@addaleax@vsemozhetbyt@ronkorving@cjihrig@gireeshpunathil@lundibundi@BethGriggs@nodejs-github-bot