Skip to content

test: fix assert.strictEqual#24619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sakit0 wants to merge 1 commit into from
Closed

test: fix assert.strictEqual#24619

sakit0 wants to merge 1 commit into from

Conversation

@sakit0
Copy link
Contributor

@sakit0sakit0 commented Nov 24, 2018•
edited
Loading

test: fix assert.strictEqual

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@hiroppyhiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18938/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 24, 2018

fast-tracks? pls 👍

@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2018

windows-fanned -> vs2017 -> test-stream-pipeline is a known failure, ref: #24456 . everything else fine; landing.

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2018

landed as 7b50258

thank you @sakito21 for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
@sakit0@gireeshpunathil
test: fix assert.strictEqual
7b50258
PR-URL: nodejs#24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 25, 2018
@sakit0@targos
test: fix assert.strictEqual
94da661
PR-URL: #24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@sakit0@rvagg
test: fix assert.strictEqual
12d7107
PR-URL: #24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sakit0@refack
test: fix assert.strictEqual
1b310ae
PR-URL: nodejs#24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@sakit0@BethGriggs
test: fix assert.strictEqual
7f0fb16
PR-URL: #24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@sakit0@rvagg
test: fix assert.strictEqual
b219131
PR-URL: #24619 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+1 more reviewer

@LekoLekoLeko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sakit0@gireeshpunathil@Leko@lpinca@targos@cjihrig@hiroppy@BethGriggs@nodejs-github-bot