tools,doc: fix version picker bug in html.js#24638
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: nodejs#23979
Trott added doc 
MemberAuthor
Trott commented Nov 25, 2018
Uh oh!
There was an error while loading. Please reload this page.
vsemozhetbyt approved these changes Nov 25, 2018
BridgeAR approved these changes Nov 25, 2018
vsemozhetbyt added the author ready MemberAuthor
Trott commented Nov 25, 2018
refack approved these changes Nov 25, 2018
MemberAuthor
Trott commented Nov 25, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18963/ |
Contributor
IIUC this will not fix already published documentation packages, right? |
MemberAuthor
Trott commented Nov 25, 2018
Correct, but it will fix all the HTML versions of the docs hosted on the website for currently-supported release lines. I think that's sufficient. I don't think this warrants digging into 13 previous 8.x releases to correct a menu item in one or two files. It's a fair amount of work and I'm not sure that the messing-with-history is worth it? (We don't go back and change outright errors in docs for previous versions, and that would seem to be a lot more significant.) |
lpinca approved these changes Nov 25, 2018
Contributor
refack commented Nov 26, 2018
💯 |
js-kyle approved these changes Nov 26, 2018
fhinkel approved these changes Nov 27, 2018
MemberAuthor
Trott commented Nov 28, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18968/ |
MemberAuthor
Trott commented Nov 28, 2018
Landed in 6f64cda |
Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: nodejs#23979 PR-URL: nodejs#24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
targos pushed a commit that referenced this pull request Nov 28, 2018
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: #23979 PR-URL: #24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: nodejs#23979 PR-URL: nodejs#24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: #23979 PR-URL: #24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
The processing of strings like `8.x` into a major version number and a minor version number results in minor versions that are `NaN`. In that situation, since the picker will link to the latest docs in the major version, include the version in the version picker. Fixes: #23979 PR-URL: #24638 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processing of strings like
8.xinto a major version number and aminor version number results in minor versions that are
NaN. In thatsituation, since the picker will link to the latest docs in the
major version, include the version in the version picker.
Fixes: #23979
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes