src: elevate v8 namespaces referenced#24657
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the c++ 
src/async_wrap.cc Outdated
There was a problem hiding this comment.
I think you can now unwrap this into a single line.
There was a problem hiding this comment.
Do you know what is the max width of line? Linter could break this, no?
There was a problem hiding this comment.
The max length is 80 and if you exceed that the linter will pick it up. You can run make lint-cpp to check any changes.
danbev commented Nov 28, 2018
juanarbol commented Nov 29, 2018
@rvagg 🤦♂️ My bad, at this hour I still thinking why I rebase, what a mess... |
Trottforce-pushed the src-v8-namespaces branch from 7d404f1 to 4996605Compare
Trott commented Nov 29, 2018
@juanarbol I checked out your branch and ran |
Trott commented Nov 29, 2018
juanarbol commented Nov 29, 2018
@Trott I think it's ok! Thank you!!! |
Trott commented Nov 30, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19077/ |
Trott added the author ready Trott commented Nov 30, 2018
Optimistic Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19091/ |
Trott commented Dec 1, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19105/ |
Trott commented Dec 1, 2018
Landed in d4273c4 |
PR-URL: nodejs#24657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #24657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: nodejs#24657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #24657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #24657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
12 participants
I saw non elevated v8 namespaces, and
v8::HandleScopealready elevated but invocated asv8::HandleScopenot justHandleScopeChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes