Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Fix sort orders of sections and bottom references.
  • Fix links.
  • Unify spelling.
  • Add missing YAML block.

* Fix sort orders of sections and bottom references. * Fix links. * Unify spelling. * Add missing YAML block.
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 28, 2018
@vsemozhetbyt
Copy link
ContributorAuthor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Nov 28, 2018
@vsemozhetbytvsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 28, 2018
@vsemozhetbyt
Copy link
ContributorAuthor

Landed in acedf1a
Thank you for the reviews.

@vsemozhetbytvsemozhetbyt deleted the doc-http-s-headers-timeout branch November 28, 2018 18:18
vsemozhetbyt added a commit that referenced this pull request Nov 28, 2018
* Fix sort orders of sections and bottom references. * Fix links. * Unify spelling. * Add missing YAML block. PR-URL: #24697 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
* Fix sort orders of sections and bottom references. * Fix links. * Unify spelling. * Add missing YAML block. PR-URL: #24697 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
* Fix sort orders of sections and bottom references. * Fix links. * Unify spelling. * Add missing YAML block. PR-URL: nodejs#24697 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.httpIssues or PRs related to the http subsystem.httpsIssues or PRs related to the https subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@vsemozhetbyt@nodejs-github-bot@sam-github@antsmartian@cjihrig@devsnek@BethGriggs