Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
doc: describe current HTTP header size limit#24700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Nov 28, 2018
sam-github commented Nov 28, 2018
mcollina left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693
bfb4d4a to 19cdee8CompareUh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: sam-github <[email protected]>
sam-github commented Nov 28, 2018
sorry, misunderstood format of description field |
vsemozhetbyt commented Nov 28, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt commented Nov 28, 2018
Trott commented Nov 28, 2018
Landed in 063e8fb |
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693 PR-URL: nodejs#24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693 PR-URL: nodejs#24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: #24693
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes