Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
deps: upgrade npm to 6.5.0#24734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 6.5.0 #24734
Uh oh!
There was an error while loading. Please reload this page.
Conversation
aeschright commented Nov 29, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
zkat commented Nov 30, 2018
Oh right, node@11 is out now too. Should we add it to the list? |
targos commented Nov 30, 2018
@zkat Do you mean the "Where this should land" list? |
Trott commented Dec 2, 2018
This needs some reviews, although I imagine they'll be largely of the rubber-stamp variety... @nodejs/npm |
Trott commented Dec 2, 2018
addaleax left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
addaleax commented Dec 4, 2018
Only failure is a known flake … Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19187/ |
targos commented Dec 4, 2018
Blocking until npm |
Trott commented Dec 4, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/19197/ ✔️ |
MylesBorins commented Dec 11, 2018
6.5.0 has been promoted to latest... as such we can land this on December 25th... A holiday present! |
MylesBorins commented Dec 25, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Other CI results are stale: https://ci.nodejs.org/job/node-test-pull-request/19793/ edit: Two flakes on AIX, re-running: https://ci.nodejs.org/job/node-test-commit-aix/20022/ |
MylesBorins commented Dec 25, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
rebased against master, one more CI https://ci.nodejs.org/job/node-test-pull-request/19798/ |
MylesBorins left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MylesBorins commented Dec 25, 2018
landed in 13ae538 |
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: nodejs#24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
PR-URL: nodejs#24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) nodejs#24811 * crypto: - always accept certificates as public keys (Tobias Nießen) nodejs#24234 - add key object API (Tobias Nießen) [nodejs#24234](nodejs#24234) - update root certificates (Sam Roberts) nodejs#25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) nodejs#25078 - upgrade npm to 6.5.0 (Audrey Eschright) nodejs#24734 * http: - add maxHeaderSize property (cjihrig) nodejs#24860 PR-URL: nodejs#25175
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #24734 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesWhere this should land
Notable Changes
This is a pre-release of
[email protected]including a number of bugfixes and documentation updates.fc1a8d185Backronymnpm citonpm clean-install. (@zkat)89652cb9bnpm.community#1661 Fix sign-git-commit options. They were previously totally wrong. (@zkat)d3e8a7c72npm.community#2303 Make summary output fornpm cigo tostdout, notstderr. (@alopezsanchez)Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog.
Changelogs