test: check for the correct strict equal arguments order#24752
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order.
MemberAuthor
BridgeAR commented Dec 2, 2018
@nodejs/testing @nodejs/linting PTAL |
MemberAuthor
BridgeAR commented Dec 3, 2018
This needs some LGs. This activates the eslint rule used so far for Code & Learn events to switch to the correct assertion argument order. These are now all in place and we should activate the rule to prevent further mistakes. |
Member
gireeshpunathil commented Dec 3, 2018
@BridgeAR - can you pls confirm the following?
pls let me know, thanks. |
MemberAuthor
BridgeAR commented Dec 3, 2018
@gireeshpunathil all are correct. |
gireeshpunathil approved these changes Dec 3, 2018
addaleax approved these changes Dec 4, 2018
Member
addaleax commented Dec 4, 2018
CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/19186/ |
addaleax added the author ready 
Trott approved these changes Dec 4, 2018
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM if lint and CI are green. Thanks!
Member
Trott commented Dec 4, 2018
Landed in 9e12409 |
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2018
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order. PR-URL: nodejs#24752 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order. PR-URL: #24752 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order. PR-URL: nodejs#24752 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This activates a eslint rule to verify that the
assert.strictEqual()arguments are in the correct order.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes