doc: streamline Accepting Modifications in Collaborator Guide#24807
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Editing a sentence I missed simplifying in the last pass on that section.
richardlau approved these changes Dec 3, 2018
BridgeAR approved these changes Dec 3, 2018
vsemozhetbyt approved these changes Dec 3, 2018
vsemozhetbyt added author ready 
MemberAuthor
Trott commented Dec 3, 2018
Landed in 2e03b76 |
Trott added a commit to Trott/io.js that referenced this pull request Dec 3, 2018
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: nodejs#24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: #24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: nodejs#24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: #24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: #24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: #24807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a sentence I missed simplifying in the last pass on that
section.
Collaborators, 👍 here to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes