minor test fixes for addons-napi / napi-api#24839
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added node-api 
MemberAuthor
cjihrig approved these changes Dec 4, 2018
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
richardlau approved these changes Dec 5, 2018
danbev approved these changes Dec 5, 2018
MemberAuthor
Trott commented Dec 5, 2018
Landed in a845d7a...06e5afa |
Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collaborators, 👍 here to fast-track.
/cc @gabrielschulhof
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes