Skip to content

tools: update ESLint to 5.10.0#24903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjihrig merged 1 commit into from
Dec 10, 2018
Merged

tools: update ESLint to 5.10.0 #24903

cjihrig merged 1 commit into from
Dec 10, 2018

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Dec 8, 2018

Update ESLint to 5.10.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1866/pipeline

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 8, 2018
BridgeAR
BridgeAR approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@BridgeARBridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

targos
targos approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@targostargos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Copy link
Member

Trott commented Dec 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19346/ ✔️

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2018
fhinkel
fhinkel approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@fhinkelfhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjihrig
tools: update ESLint to 5.10.0
cc8250f
Update ESLint to 5.10.0. PR-URL: nodejs#24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@cjihrigcjihrig merged commit cc8250f into nodejs:masterDec 10, 2018
@cjihrigcjihrig deleted the eslint branch December 10, 2018 13:53
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@cjihrig@BethGriggs
tools: update ESLint to 5.10.0
ad6104d
Update ESLint to 5.10.0. PR-URL: #24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
BethGriggs added a commit that referenced this pull request Dec 18, 2018
@BethGriggs
2018-12-18, Version 11.5.0 (Current)
c911de2
Notable changes: * **test**: * test TLS client authentication (Sam Roberts) [#24733](#24733) * **tls**: * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts) [#24733](#24733) * **tools**: * update ESLint to 5.10.0 (cjihrig) [#24903](#24903) * **util**: * add inspection getter option (Ruben Bridgewater) [#24852](#24852) PR-URL: #25102
MylesBorins pushed a commit that referenced this pull request Dec 18, 2018
@BethGriggs@MylesBorins
2018-12-18, Version 11.5.0 (Current)
3a4c67d
Notable changes: * **test**: * test TLS client authentication (Sam Roberts) [#24733](#24733) * **tls**: * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts) [#24733](#24733) * **tools**: * update ESLint to 5.10.0 (cjihrig) [#24903](#24903) * **util**: * add inspection getter option (Ruben Bridgewater) [#24852](#24852) PR-URL: #25102
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig@refack
tools: update ESLint to 5.10.0
cf02fcf
Update ESLint to 5.10.0. PR-URL: nodejs#24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@cjihrig@BethGriggs
tools: update ESLint to 5.10.0
34212b5
Update ESLint to 5.10.0. PR-URL: #24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@cjihrig@BethGriggs
tools: update ESLint to 5.10.0
306c009
Update ESLint to 5.10.0. PR-URL: #24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig@rvagg
tools: update ESLint to 5.10.0
fb4ce8b
Update ESLint to 5.10.0. PR-URL: #24903 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes

@targostargostargos approved these changes

@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cjihrig@nodejs-github-bot@Trott@fhinkel@targos@BridgeAR@BethGriggs