Skip to content

doc: revise internal vs. public API in Collaborator Guide#24975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 2 commits into from
Closed

doc: revise internal vs. public API in Collaborator Guide #24975

Trott wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Dec 11, 2018

Make the Collaborator Guide section "Internal vs. Public API" more
concise and clear. Remove repetition. Clarify some ambiguity.
wordy, repetitive, and somewhat

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: revise internal vs. public API in Collaborator Guide
3603497
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2018

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1904/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 11, 2018
richardlau
richardlau reviewed Dec 11, 2018
View reviewed changes
@Trott
Copy link
MemberAuthor

Trott commented Dec 12, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1905/

@TrottTrott closed this Dec 12, 2018
@TrottTrott reopened this Dec 12, 2018
@Trott
Copy link
MemberAuthor

Trott commented Dec 14, 2018

Needs another review before it can land.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018
@Trott
Copy link
MemberAuthor

Trott commented Dec 14, 2018

Landed in 9f37f9c

@TrottTrott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
doc: revise internal vs. public API in Collaborator Guide
9f37f9c
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: nodejs#24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott@BethGriggs
doc: revise internal vs. public API in Collaborator Guide
877f8a0
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: #24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott@refack
doc: revise internal vs. public API in Collaborator Guide
d355aa8
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: nodejs#24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott@BethGriggs
doc: revise internal vs. public API in Collaborator Guide
8f43441
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: #24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott@BethGriggs
doc: revise internal vs. public API in Collaborator Guide
cb681ed
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: #24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott@rvagg
doc: revise internal vs. public API in Collaborator Guide
c580057
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: #24975 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@TrottTrott deleted the internal-vs-public branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@joyeecheung@richardlau@BethGriggs