test: add stdout check to test-esm-cjs-main#25073
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Dec 16, 2018
richardlau approved these changes Dec 16, 2018
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
LGTM if we rename the parameter.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Trott commented Dec 16, 2018
Trott added the author ready 
antsmartian approved these changes Dec 16, 2018
MemberAuthor
Trott commented Dec 16, 2018
Note to whoever lands this (which will probably be me): The commit message needs to be edited as it's checking |
cjihrig approved these changes Dec 16, 2018
MemberAuthor
Trott commented Dec 16, 2018
Only red in the CI seems to be because the cleanup detected that @gireeshpunathil was testing something on CI: 21:45:21 ps awwx | grep Release/node | grep -v grep | cat21:45:21 32506076 pts/2 A 0:00 /home/iojs/gireesh/exitrace/node/out/Release/node -e console.log('foobar'); 21:45:21 gmake[1]: *** [test-ci] Error 1If we see this happening a lot, we'll mark the node offline in Jenkins while they're doing their work (which is something we should do anyway, but we'd need some pretty responsive/on-duty Build folks to oversee it because right now we have them on one AIX node and @gabrielschulhof working on the other, so we'd have no AIX nodes left online potentially). TL;DR Red CI here is unrelated and we'll Resume Build anyway. |
MemberAuthor
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19585/ ✔️ |
watilde approved these changes Dec 16, 2018
lpinca approved these changes Dec 16, 2018
jasnell approved these changes Dec 17, 2018
MemberAuthor
Trott commented Dec 18, 2018
Landed in dbdfc5d |
Trott added a commit to Trott/io.js that referenced this pull request Dec 18, 2018
PR-URL: nodejs#25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
PR-URL: #25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
PR-URL: #25073 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes