process: make internal/queue_microtask.js more self-contained#25189
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
MemberAuthor
joyeecheung commented Dec 23, 2018
devsnek approved these changes Dec 23, 2018
Trott reviewed Dec 23, 2018
Uh oh!
There was an error while loading. Please reload this page.
Trott reviewed Dec 23, 2018
Uh oh!
There was an error while loading. Please reload this page.
jasnell approved these changes Dec 23, 2018
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function.
joyeecheungforce-pushed the queue-microtask branch from 0c674c9 to cfb7811CompareMemberAuthor
joyeecheung commented Dec 24, 2018
Rebased and fixed linter errors: https://ci.nodejs.org/job/node-test-pull-request/19773/ |
Member
BridgeAR approved these changes Dec 24, 2018
BridgeAR added the author ready MemberAuthor
joyeecheung commented Dec 29, 2018
Landed in 8a60be4 |
joyeecheung added a commit that referenced this pull request Dec 29, 2018
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function. PR-URL: #25189 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
addaleax commented Jan 5, 2019
Should this be backported to |
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function. PR-URL: nodejs#25189 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>Member
addaleax commented Jan 15, 2019
This lands cleanly now. |
addaleax pushed a commit that referenced this pull request Jan 15, 2019
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function. PR-URL: #25189 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function. PR-URL: nodejs#25189 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
- Instead of passing triggerFatalException through node.js, simply put it on `internalBinding('util')` which has to be loaded anyway. - Expose the implementation of `queueMicrotask` directly instead of through an unnecessary factory function. PR-URL: nodejs#25189 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simply put it on
internalBinding('util')which has to beloaded anyway.
queueMicrotaskdirectly insteadof through an unnecessary factory function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes